General GUI cleanup by Aurumaker72 · Pull Request #92 · Key2Joy/Key2Joy

Aurumaker72 · 2025-10-30T22:41:59Z

Summary

This PR does a general cleanup pass for the UI. Note that these changes are pretty strongly opinionated.

Connection UI/UX

The "Arm Mappings" checkbox is now a ToggleButton-like Checkbox that alternates its text between "Connect" and "Disconnect", and the mappings status label has been removed.

Device List

The device list has been enhanced to have a better placeholder, and device controls themselves have gotten a tighter layout.

The animation for device connecting/disconnecting has been removed, primarily because it didn't communicate any particularly important information. Given that this is an opinionated change, it can be reverted.

Search Box

The search box has been moved above the listview and to the left of the profile textbox to make the UI flow more naturally. It has also been given a search icon.

Maximize Button

The maximize button has been re-enabled. Not sure why that was disabled.

Font Consistency

Some random bits and bobs used Arial instead of MS Sans Serif, so that has been changed to be more consistent.

Config Dialog

The save button has been shrunk and moved to the standard action button location (bottom right). It also no longer shows a messagebox after clicking it.

The dialog can now be resized, and its titlebar displays the text "Configuration" has no icon anymore.
The default positioning behaviour is now also centering to parent.

There is now a hotkey (Ctrl + ,) for opening the configuration dialog.

Other Stuff

There's a fix for a compilation error caused by a breaking change in Jint. Not sure how that happened.

Copilot

Pull Request Overview

This pull request updates the UI layout and removes unused functionality from the Key2Joy application. The changes improve the interface by simplifying status indicators, relocating controls, and updating styling for better visual consistency.

Replaced status labels with a connect/disconnect button for clearer user interaction
Removed the "Save Profile" menu item and related functionality (as profiles auto-save)
Removed device activity animation/fade effect code
Updated API call from deprecated Environment.Realm.GlobalObject to Environment.Global

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
Key2Joy.Gui/MainForm.cs	Removed ConfigureStatusLabels method and SaveProfileToolStripMenuItem_Click handler; updated SetStatusView to use button text instead of labels
Key2Joy.Gui/MainForm.Designer.cs	Major UI layout changes: removed status labels, moved filter controls to profile panel, changed checkbox to button, removed save profile menu item, updated colors and sizes
Key2Joy.Gui/MainForm.resx	Removed BOM character from XML declaration
Key2Joy.Gui/DeviceControl.cs	Removed device activity animation feature including fade timer, paint handler, and color interpolation logic
Key2Joy.Gui/DeviceListControl.Designer.cs	Updated panel colors from black/gold to transparent, adjusted sizes and margins
Key2Joy.Gui/DeviceListControl.resx	Removed BOM character from XML declaration
Core/Key2Joy.Core/Mapping/Actions/Scripting/JavascriptScriptAction.cs	Updated to use Environment.Global instead of Environment.Realm.GlobalObject

Files not reviewed (2)

Key2Joy.Gui/DeviceListControl.Designer.cs: Language not supported
Key2Joy.Gui/MainForm.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T23:01:34Z

Core/Key2Joy.Core/Mapping/Actions/Scripting/JavascriptScriptAction.cs

        var methodInfo = exposedMethod.GetExecutorMethodInfo();
        var @delegate = new DelegateWrapper(this.Environment, methodInfo.CreateDelegate(exposedMethod));
-        var currentObject = this.Environment.Realm.GlobalObject;
+        var currentObject = this.Environment.Global;


The change from Environment.Realm.GlobalObject to Environment.Global suggests a Jint API update. Ensure that Environment.Global provides the same type and functionality as the previous Realm.GlobalObject. Verify that downstream usages (e.g., TryGetValue, FastSetProperty) remain compatible with the new property.

Suggested change

var currentObject = this.Environment.Global;

if (this.Environment.Global is not ObjectInstance globalObject)

throw new InvalidOperationException("Environment.Global is not an ObjectInstance. Cannot register scripting method.");

var currentObject = globalObject;

For reference: I was using a Jint preview build from a non-default NuGet registry since 3.0.0 didn't exist yet back when I worked on this.

Could you do me another favor and make 3.0.0 the version depended on in Core/Key2Joy.Core/Key2Joy.Core.csproj? It's currently set to 3.0.0-preview-488 which I guess resolves to 3.0.0 in your IDE, resulting in it working fine.

Copilot · 2025-10-30T23:01:35Z

Key2Joy.Gui/MainForm.Designer.cs

            // chkArmed
            // 
-            this.chkArmed.AutoSize = true;
+            this.chkArmed.Appearance = System.Windows.Forms.Appearance.Button;


Converting the checkbox to a button appearance may affect keyboard accessibility. Ensure that space bar toggling still works as expected for users who navigate via keyboard, since button-styled checkboxes can sometimes behave differently from standard checkboxes.

Copilot · 2025-10-30T23:01:35Z

Key2Joy.Gui/DeviceControl.cs

        this.lblIndex.Text = $"#{device.Index}";
        this.lblDevice.Text = device.Name;


The device parameter is no longer stored in the field (removed line this.device = device;), but the constructor still accepts it and uses it. If the device reference is needed later in the class lifecycle, removing this field assignment could cause issues. If it's truly unused, consider whether the event handler unsubscription device.ActivityOccurred -= ... is still handled elsewhere to prevent memory leaks.

use ms sans serif font everywhere instead of arial

now defined in the designer and has its visibility toggled programmatically also the wording has been improved somewhat

Copilot

Pull Request Overview

Copilot reviewed 7 out of 10 changed files in this pull request and generated 1 comment.

Files not reviewed (3)

Key2Joy.Gui/DeviceControl.Designer.cs: Language not supported
Key2Joy.Gui/DeviceListControl.Designer.cs: Language not supported
Key2Joy.Gui/MainForm.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Key2Joy.Gui/DeviceListControl.Designer.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

has no effect on functionality

luttje · 2025-11-01T07:51:37Z

I don't recall enabling copilot as an automated reviewer @Aurumaker72. Let me know if it hinders you in getting work done and I will disable it. In any case: seeing you work on it this so actively is inspiring! Thanks again!

Aurumaker72 · 2025-11-01T09:20:13Z

I don't recall enabling copilot as an automated reviewer @Aurumaker72. Let me know if it hinders you in getting work done and I will disable it. In any case: seeing you work on it this so actively is inspiring! Thanks again!

I think GitHub A/B tests it and it was just enabled for this repo as well. It's fine, though, pretty neat feature imo 😄

I will continue work on this PR and will mark it when it's ready 👍

Copilot

Pull Request Overview

Copilot reviewed 9 out of 15 changed files in this pull request and generated 1 comment.

Files not reviewed (5)

Key2Joy.Gui/ConfigForm.Designer.cs: Language not supported
Key2Joy.Gui/DeviceControl.Designer.cs: Language not supported
Key2Joy.Gui/DeviceListControl.Designer.cs: Language not supported
Key2Joy.Gui/MainForm.Designer.cs: Language not supported
Key2Joy.Gui/Properties/Resources.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-01T11:46:34Z

Key2Joy.Gui/MainForm.Designer.cs

+            // 
+            this.exitProgramToolStripMenuItem.Image = global::Key2Joy.Gui.Properties.Resources.door_out;
+            this.exitProgramToolStripMenuItem.Name = "exitProgramToolStripMenuItem";
+            this.exitProgramToolStripMenuItem.ShortcutKeys = ((System.Windows.Forms.Keys)((System.Windows.Forms.Keys.Alt | System.Windows.Forms.Keys.F4)));


Alt+F4 is a system-wide shortcut for closing windows in Windows. Explicitly assigning it to the Exit menu item is unnecessary and could potentially interfere with the default behavior or create confusion if the shortcut is disabled. Consider removing this assignment to rely on the default system behavior.

Suggested change

this.exitProgramToolStripMenuItem.ShortcutKeys = ((System.Windows.Forms.Keys)((System.Windows.Forms.Keys.Alt | System.Windows.Forms.Keys.F4)));

There's no interference afaics, and it's just there to display the standard shortcut text (aka accelerator text)

luttje

I can follow the reasoning behind your UX changes. Thanks for lending your expertise on this matter. The changes LGTM, thanks!

I have one small request for a change, to do with the Jint version we depend on. If you can change that to 3.0.0 for us that'd be great.

After that I will approve and merge these changes. 👍

luttje · 2025-11-01T16:36:39Z

Core/Key2Joy.Core/Mapping/Actions/Scripting/JavascriptScriptAction.cs

        var methodInfo = exposedMethod.GetExecutorMethodInfo();
        var @delegate = new DelegateWrapper(this.Environment, methodInfo.CreateDelegate(exposedMethod));
-        var currentObject = this.Environment.Realm.GlobalObject;
+        var currentObject = this.Environment.Global;


For reference: I was using a Jint preview build from a non-default NuGet registry since 3.0.0 didn't exist yet back when I worked on this.

Could you do me another favor and make 3.0.0 the version depended on in Core/Key2Joy.Core/Key2Joy.Core.csproj? It's currently set to 3.0.0-preview-488 which I guess resolves to 3.0.0 in your IDE, resulting in it working fine.

Aurumaker72 · 2025-11-01T18:04:49Z

I can follow the reasoning behind your UX changes. Thanks for lending your expertise on this matter. The changes LGTM, thanks!

I have one small request for a change, to do with the Jint version we depend on. If you can change that to 3.0.0 for us that'd be great.

After that I will approve and merge these changes. 👍

Yeah, sure, I can do that :)

luttje · 2025-11-01T19:08:53Z

Thanks for these contributions!

Aurumaker72 added 6 commits October 26, 2025 22:36

fix js env reference

4cfced6

simplify connection UX

0930ee9

remove save profile menu item

0b96b17

move search into top bar, move connect/disconnect button into top bar

8c46c08

enable maximize button

0205f3e

remove device fade animation

3b0c5c1

Aurumaker72 marked this pull request as ready for review October 30, 2025 22:58

Copilot AI review requested due to automatic review settings October 30, 2025 22:58

Aurumaker72 marked this pull request as draft October 30, 2025 23:00

Copilot AI reviewed Oct 30, 2025

View reviewed changes

Aurumaker72 added 3 commits October 31, 2025 00:30

improve font consistency

eb87def

use ms sans serif font everywhere instead of arial

clean up device list placeholder

6c498ca

now defined in the designer and has its visibility toggled programmatically also the wording has been improved somewhat

shrink device control, give it a raised background color

fd22dc3

Aurumaker72 requested a review from Copilot October 30, 2025 23:52

Copilot AI reviewed Oct 30, 2025

View reviewed changes

Key2Joy.Gui/DeviceListControl.Designer.cs Outdated Show resolved Hide resolved

Aurumaker72 and others added 3 commits October 31, 2025 09:31

fix app name in device list placeholder

9f42fee

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

remove layout hack from DeviceControl

a8de4a7

has no effect on functionality

Merge branch 'main' of https://github.com/Aurumaker72/WinGamepadEmu

cebbd14

Aurumaker72 added 10 commits November 1, 2025 10:26

shrink save button in config dialog

60882f6

dont show messagebox after saving config

46122a7

allow resizing config dialog, set positioning to center to parent

520fc8d

remove icon from config dialog, change titlebar text to "Configuration"

4b10cfe

rename "Exit Application" menu item to "Exit" and add accelerator text

8cc8dba

reanme "User Configuration" menu item to "Configuration"

52d9cc1

add Ctrl + , shortcut for opening config dialog

dde848a

improve device list margins and paddings

ce3fd7b

fix text cutoff

4b645c0

add icon to search label, move search to the left of the profile textbox

dc7638b

Aurumaker72 mentioned this pull request Nov 1, 2025

Move Connect/Disconnect button into Device List #95

Closed

Aurumaker72 marked this pull request as ready for review November 1, 2025 11:43

Aurumaker72 requested a review from Copilot November 1, 2025 11:43

Copilot AI reviewed Nov 1, 2025

View reviewed changes

use separators to distinguish between devices

f2b67c7

luttje self-requested a review November 1, 2025 16:33

luttje requested changes Nov 1, 2025

View reviewed changes

update Jint package to 3.0.0

6c5911b

luttje merged commit fdfdfe1 into Key2Joy:main Nov 1, 2025
1 check passed

-        var currentObject = this.Environment.Global;
+        if (this.Environment.Global is not ObjectInstance globalObject)
+            throw new InvalidOperationException("Environment.Global is not an ObjectInstance. Cannot register scripting method.");
+        var currentObject = globalObject;

		this.lblIndex.Text = $"#{device.Index}";
		this.lblDevice.Text = device.Name;

Conversation

Aurumaker72 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Connection UI/UX

Device List

Menu

Search Box

Maximize Button

Font Consistency

Config Dialog

Other Stuff

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

luttje Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

luttje commented Nov 1, 2025

Uh oh!

Aurumaker72 commented Nov 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Aurumaker72 Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

luttje left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luttje Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Aurumaker72 commented Nov 1, 2025

Uh oh!

Uh oh!

luttje commented Nov 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Aurumaker72 commented Oct 30, 2025 •

edited

Loading

luttje left a comment •

edited

Loading