Move selection-related list view context actions into its context menu#111
Merged
Aurumaker72 merged 3 commits intomainfrom Jan 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the "Generate Reverse Mappings" functionality from the main menu bar to the list view's context menu. The change improves discoverability by placing the action closer to where users interact with mappings.
Changes:
- Moved "Generate Reverse Mappings" from main menu's "Tools > With Selected..." to the context menu
- Refactored event handling to use the existing
MappingContextMenuBuilderpattern - Removed main menu strip items and their associated event handler
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Key2Joy.Gui/MappingContextMenuBuilder.cs | Added event and menu item for Generate Reverse Mappings in context menu |
| Key2Joy.Gui/MainForm.cs | Moved method logic and wired up context menu event handler, removed old menu event handler |
| Key2Joy.Gui/MainForm.Designer.cs | Removed menu strip items for "With Selected" submenu and Generate Reverse Mappings option |
| Key2Joy.Gui/MainForm.resx | Minor formatting change from Designer updates |
Files not reviewed (1)
- Key2Joy.Gui/MainForm.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
luttje
approved these changes
Jan 11, 2026
Collaborator
luttje
left a comment
There was a problem hiding this comment.
Tested it, works great! Much smarter to have it as a context menu option 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move selection-related list view context actions out of the main menu strip and into its context menu.