Merged
Conversation
Keats
reviewed
Aug 26, 2024
|
|
||
| // And now generate the files in the output dir given | ||
| let walker = WalkDir::new(&start_path) | ||
| let walker = WalkDir::new(&start_path).follow_links(definition.symlinks) |
Contributor
Author
There was a problem hiding this comment.
I wasn't sure of the original intent so I left it disabled by default, but I'm all for having it be the default case as long as it handles cycles during the walk and it doesn't effect Windows users. I'll test and makes sure that it doesn't introduce any issues there and if not make it the default.
Owner
There was a problem hiding this comment.
Initially the use case was for templates to be self contained, eg a git repo so there was no real need for symlinks
| name = "Test template" | ||
| description = "A description" | ||
| kickstart_version = 1 | ||
| symlinks = false |
Owner
There was a problem hiding this comment.
If we use an option, I'd rather have it follow_symlinks
Contributor
Author
There was a problem hiding this comment.
much more descriptive, agreed. I'll make that change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was recently shopping around for a good scaffolding tool for projects and found kickstart, the only feature missing for me was the ability to follow symlinks so I can share common files between templates. This simple PR adds the ability to follow symlinks as a template config parameter but does not change the default behavior.