Skip to content

Crashing error when signing fails #473

@Julien-cpsn

Description

@Julien-cpsn

Hello,

Thanks for this great library.

The problem occurs when users try to use the encode function.
Inside encode at line 189 you call the sign method, which crashes the whole application when failing. In ATAC, users may use custom stuff and it will lead to crashes.

let signature = b64_encode(signing_provider.sign(message.as_bytes()));

It would be better to use the try_sign method, which will not crash.

If you don't want such a thing, then it would be great to have a try_encode function.

Have a great day

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions