Skip to content

Update Scikit-learn to 0.20.1#2143

Closed
jnothman wants to merge 1 commit intoKapeli:masterfrom
jnothman:scikit-learn-0.20.1
Closed

Update Scikit-learn to 0.20.1#2143
jnothman wants to merge 1 commit intoKapeli:masterfrom
jnothman:scikit-learn-0.20.1

Conversation

@jnothman
Copy link
Copy Markdown
Contributor

@jnothman jnothman commented Nov 25, 2018

Also updated build.sh to account for:

  • non-mac mktemp
  • virtualenv not installed in env
  • pip needing upgrade
  • additional doc dependencies for Scikit-learn 0.20

@jnothman
Copy link
Copy Markdown
Contributor Author

jnothman commented Nov 27, 2018

Please advise on how to interpret the errors:

File not found at "modules/generated/sklearn.cluster.dbscan.html" for entry with row id "1909" of "scikit-learn.docset"
File not found at "modules/generated/sklearn.covariance.oas.html" for entry with row id "1921" of "scikit-learn.docset"
File not found at "modules/generated/sklearn.decomposition.fastica.html" for entry with row id "1974" of "scikit-learn.docset"

when

$ tar tzvf scikit-learn.tgz | grep sklearn.cluster.dbscan
-rw-r--r-- joel/group      228 2018-11-25 23:50 scikit-learn.docset/Contents/Resources/Documents/_sources/modules/generated/sklearn.cluster.dbscan.rst.txt
-rw-r--r-- joel/group    16990 2018-11-26 01:13 scikit-learn.docset/Contents/Resources/Documents/modules/generated/sklearn.cluster.dbscan.html

@Kapeli
Copy link
Copy Markdown
Owner

Kapeli commented Nov 29, 2018

You archive contains the following files:

scikit-learn.docset/Contents/Resources/Documents/modules/generated/sklearn.cluster.dbscan.html
scikit-learn.docset/Contents/Resources/Documents/modules/generated/sklearn.cluster.DBSCAN.html

When unarchiving on a case-insensitive system you get only one, but not the other, hence the error.

Is this something you could fix?

@jnothman jnothman mentioned this pull request Dec 2, 2018
Closed
@Kapeli
Copy link
Copy Markdown
Owner

Kapeli commented Dec 13, 2018

Closing due to inactivity. Please open a new pull request when ready.

@Kapeli Kapeli closed this Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnothman @Kapeli