Conversation
There was a problem hiding this comment.
PR review — approve/close
Context applied: v1.5 “pragmatic auth groundwork” for OSS with K8s edge security.
Given this scope, I see no blocking issues.
Notes (non‑blocking, can follow up)
Multi‑group authorization in DescribeGroups/DeleteGroups is currently all‑or‑nothing; consider per‑group results later for correctness in mixed‑visibility scenarios.
Everything else aligns with the v1.5 plan (ACL checks, principal propagation, auth metrics/logs, console rate limiting, docs/tests).
|
Local tests are W.I.P..... make test-acl => passed. Ran: make test-acl make test => passed. Ran: make test (with escalated permissions) |
PR v1.5 roadmap: Auth, ACL coverage, and proxy protocol hardening
Summary
This PR implements the v1.5 auth groundwork: broker-side ACL enforcement improvements, connection-level principal plumbing with PROXY protocol support, expanded ACL test coverage, and documentation updates. It also adds rate-limited auth denial logs and tightens proxy protocol parsing behavior.
Key Changes
client_id(default),remote_addr,proxy_addr; with fail‑closed behavior when PROXY protocol is enabled.notes/directory in.gitignore.Details
KAFSCALE_PROXY_PROTOCOL=trueand header missing/invalid.TestACLsE2E).Tests
make testmake test-aclNotes for Reviewers
client_idremain spoofable unless trusted edge auth is enforced; warnings are logged on startup.