Merged
Conversation
Fix KaTeX#353 using `buildCommon.makeSymbol` to automatically determine font for the accent symbol.
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
+ Coverage 94.81% 94.81% +<.01%
==========================================
Files 81 81
Lines 5281 5282 +1
Branches 923 923
==========================================
+ Hits 5007 5008 +1
Misses 250 250
Partials 24 24
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
+ Coverage 94.82% 94.83% +<.01%
==========================================
Files 81 81
Lines 5280 5281 +1
Branches 923 923
==========================================
+ Hits 5007 5008 +1
Misses 249 249
Partials 24 24
Continue to review full report at Codecov.
|
ylemkimon
approved these changes
Aug 20, 2019
Member
Author
|
@ylemkimon Thanks for the review! |
Member
|
@edemaine Thank you for tackling the long-standing problem! |
Member
|
This is awesome! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #353 using
buildCommon.makeSymbolto automatically determine font for the accent symbol.I'd forgotten about this issue but @kevinbarabash's recent post in it caused me to look at it again. I believe the fix is quite simple with the current code (much revised since the issue was first raised).
Example:
As a bonus, this also fixes #1099: turns out the issue there was not using the italic-font accents within
\textit.The screenshot diffs highlight the improvements (green is new):
MathIt:
MathBf:
MathSf:
MathTt: