Fix \KaTeX macro definition in tests#1843
Merged
ylemkimon merged 2 commits intoKaTeX:masterfrom Feb 21, 2019
Merged
Conversation
Update `test/screenshotter/test.tex`'s definition of `\KaTeX` macro to match the metrics of `src/macros.js`'s definition of `\KaTeX`, and thereby fix KaTeX#1703. I just changed the `\kern` metrics to match the update from KaTeX#974, and left the font selection code to match LaTeX's definition of `\LaTeX`.
Codecov Report
@@ Coverage Diff @@
## master #1843 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 79 79
Lines 4659 4659
Branches 810 810
=======================================
Hits 4414 4414
Misses 221 221
Partials 24 24
Continue to review full report at Codecov.
|
ylemkimon
approved these changes
Feb 21, 2019
Member
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
test/screenshotter/test.tex's definition of\KaTeXmacro to match the metrics ofsrc/macros.js's definition of\KaTeX, and thereby fix #1703. (Thanks @ylemkimon for spotting this! Sorry for the delay in fixing.)I just changed the
\kernmetrics to match the update from #974, and left the font selection code to match LaTeX's definition of\LaTeX.New texcmp:
Here's what it used to look like (from #1703):