Skip to content

Replace Khan/KaTeX with KaTeX/KaTeX#1781

Merged
k4b7 merged 3 commits intoKaTeX:masterfrom
ylemkimon:repo-rename
Nov 20, 2018
Merged

Replace Khan/KaTeX with KaTeX/KaTeX#1781
k4b7 merged 3 commits intoKaTeX:masterfrom
ylemkimon:repo-rename

Conversation

@ylemkimon
Copy link
Member

@codecov-io
Copy link

Codecov Report

Merging #1781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1781   +/-   ##
=======================================
  Coverage   93.67%   93.67%           
=======================================
  Files          80       80           
  Lines        4666     4666           
  Branches      813      813           
=======================================
  Hits         4371     4371           
  Misses        261      261           
  Partials       34       34
Flag Coverage Δ
#screenshotter 88.62% <ø> (ø) ⬆️
#test 85.04% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/symbols.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e2418...603dcb5. Read the comment docs.

Copy link
Member

@k4b7 k4b7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for removing those unused files. I wish there was a better way to deal with the RawGit issue than storing the logos in the repo. I guess if we move towards a mono-repo set up we'll have all sorts of things in the repo.

name: Check whether the build is running on the main repository
command: |
if [[ $CIRCLE_PULL_REQUEST && $CIRCLE_PROJECT_USERNAME != "Khan" ]]; then
if [[ $CIRCLE_PULL_REQUEST && $CIRCLE_PROJECT_USERNAME != "KaTeX" ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find this string b/c I was searching for locally and my search was scoped to src. 😞

@k4b7 k4b7 merged commit 112582d into KaTeX:master Nov 20, 2018
@ylemkimon
Copy link
Member Author

ylemkimon commented Nov 20, 2018

@kevinbarabash Could you check Gitter, Greenkeeper, and Netlify and Codecov status notification?

@edemaine
Copy link
Member

Thanks for the heads up about RawGit! FWIW, https://www.jsdelivr.com/rawgit suggests that we could have replaced the links to use jsDelivr, but this is more future-proof.

@k4b7
Copy link
Member

k4b7 commented Nov 20, 2018

I've updated the settings on netlify to use the new repo. I'll check the others later.

@k4b7
Copy link
Member

k4b7 commented Nov 20, 2018

For gitter I'm going to email them and see if they can transfer the existing chat room.

@k4b7
Copy link
Member

k4b7 commented Nov 21, 2018

gitter has transferred the chat room.

@ylemkimon ylemkimon deleted the repo-rename branch March 21, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove check-node-version.js Remove .arcconfig, .arclint, and lint_blacklist.txt

4 participants