Skip to content

Add 0.08em padding above \sqrt#1136

Closed
ronkok wants to merge 4 commits intoKaTeX:masterfrom
ronkok:sqrtPadding
Closed

Add 0.08em padding above \sqrt#1136
ronkok wants to merge 4 commits intoKaTeX:masterfrom
ronkok:sqrtPadding

Conversation

@ronkok
Copy link
Collaborator

@ronkok ronkok commented Feb 2, 2018

This way, any browser imprecision on the parent span.height will not encroach on the ink of the \sqrt top line.

This way, any browser imprecision on the parent span.height will not encroach on the ink of the \sqrt top line.
@k4b7
Copy link
Member

k4b7 commented Feb 3, 2018

I'll regenerate the screenshots this weekend.

@k4b7
Copy link
Member

k4b7 commented Feb 4, 2018

Swiping the Raisebox screenshots shows that the surd has come down a bit, but using texcmp it looks like it's closer to what LaTeX.
raisebox

@k4b7
Copy link
Member

k4b7 commented Feb 4, 2018

@ronkok I'm happy with how things are looking in Firefox when the font is 12px. I'm not seeing any of the clipping I was seeing before. I generated the screenshots before you merged in master so I will have to regenerate them.

Firefox: 12px @ 100%
screen shot 2018-02-04 at 5 11 19 pm

Firefox: 12px @ 50%
screen shot 2018-02-04 at 5 11 25 pm

@k4b7
Copy link
Member

k4b7 commented Feb 4, 2018

Hmm... I tried regenerating the screenshots in question based on 32682b4, but there's no change. Maybe merge with master again.

@ronkok
Copy link
Collaborator Author

ronkok commented Feb 4, 2018

I tried another merge here, too. I'm getting messages about multiple image file conflicts. I'm sorry about this, but I really don't know what to do next.

@k4b7
Copy link
Member

k4b7 commented Feb 4, 2018

@ronkok to resolve conflicts in binary files use git checkout --ours -- path_to_file or git checkout --theirs -- path_to_file. In this case it doesn't matter which one you pick b/c I'm going to regenerate the screenshots. See https://stackoverflow.com/questions/278081/resolving-a-git-conflict-with-binary-files.

@ronkok
Copy link
Collaborator Author

ronkok commented Feb 5, 2018

Closing here. Will reopen elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants