Skip to content

Extract horizBrace and xArrow commands into functions directory#1083

Closed
k4b7 wants to merge 1 commit intomasterfrom
extract_horizBrace_xArrow
Closed

Extract horizBrace and xArrow commands into functions directory#1083
k4b7 wants to merge 1 commit intomasterfrom
extract_horizBrace_xArrow

Conversation

@k4b7
Copy link
Member

@k4b7 k4b7 commented Jan 23, 2018

No description provided.

{type: "elem", elem: body},
{type: "kern", size: 0.1},
{type: "elem", elem: braceBody},
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this not have wrapperClasses: ["svg-align"],?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to double check, but I don't think it was ending up on the same element as before the change, but it didn't seem to have an impact so I removed it. @ronkok can you think of any cases where having this class would matter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinbarabash I added that class when we changed from background-image SVGs to inline SVGs in PR #807. My experience then was if that text-align: left was not applied on just the right span, then the elements would render smaller, lower, and off to the right. It was a large, very noticeable difference.

I don't know why it would be different now.

@k4b7
Copy link
Member Author

k4b7 commented Feb 1, 2018

TODO:

  • rebase and resolve conflicts
  • resolve question about svg-align class

@k4b7
Copy link
Member Author

k4b7 commented Feb 20, 2018

I'm going to close this for now and will try again once some of the other PRs have been merged.

@k4b7 k4b7 closed this Feb 20, 2018
@k4b7 k4b7 deleted the extract_horizBrace_xArrow branch May 30, 2018 13:16
@ronkok ronkok mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants