-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
documentFragment causes many problems because they differ from normal HtmlDomNode, but it implements HtmlDomNode.
This seems fine, and simpler to me, but I'll reraise a question I asked in #1439 (comment):
The one scary thing might be someone doing
myDocumentFragment.classes.push('something'), which will then act as a no-op...I think the real issue here is we're abusing the type interface. But this was true before, too. Perhaps the proper way would be to have two interfaces, one with style and one without (the former could subclass from the latter). We could save this change for another PR if you prefer.
assumes buildExpressionRow returning a documentFragment.
There are many other instances of assigning a class, a style, or an attribute to documentFragment.