Skip to content

fix: timeiotams bug#88

Merged
troykessler merged 1 commit intomainfrom
fix/celestia-time-iota
Dec 20, 2024
Merged

fix: timeiotams bug#88
troykessler merged 1 commit intomainfrom
fix/celestia-time-iota

Conversation

@troykessler
Copy link
Member

This PR fixes a bug which can be reproduced with:

ksync state-sync --opt-out -b ./celestia-appd-v2.2.0 -d -l -r -t 2400000
./celestia-appd-v2.2.0 start --p2p.seeds="ade4d8bc8cbe014af6ebdf3cb7b1e9ad36f412c0@seeds.polkachu.com:11656"

which throws the following panic:

panic: Failed to process committed block (2400001:2EBC42F0C98379203D57C118D13D2CCD9F9ADD4849A176ECCDE19808073C2D53): commit failed for application: error updating consensus params: block.TimeIotaMs must be greater than 0. Got 0

goroutine 147 [running]:
github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).poolRoutine(0x14000583c00, 0x0)
	/root/go/pkg/mod/github.com/celestiaorg/celestia-core@v1.42.0-tm-v0.34.35/blockchain/v0/reactor.go:418 +0xe44
created by github.com/tendermint/tendermint/blockchain/v0.(*BlockchainReactor).OnStart in goroutine 67
	/root/go/pkg/mod/github.com/celestiaorg/celestia-core@v1.42.0-tm-v0.34.35/blockchain/v0/reactor.go:112 +0x78

With this PR this error does not occur anymore and instead syncs the blocks normally

@troykessler troykessler self-assigned this Dec 19, 2024
@troykessler troykessler merged commit ea8e32e into main Dec 20, 2024
@troykessler troykessler deleted the fix/celestia-time-iota branch December 20, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants