fix: state-sync for cometbft-v0.38+ with vote extensions#80
Merged
troykessler merged 1 commit intomainfrom Oct 29, 2024
Merged
Conversation
christopherbrumm
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that for cometbft-v0.38+ chains with enabled vote extensions the binary panics after state- or block-syncing. Example error with dydxprotocold v6.0.4:
panic: failed to reconstruct last extended commit; extended commit for height 27890144 not found. Since vote extensions are not retrievable over the RPC and not stored for all existing pools this PR mimics the state-sync behaviour with the native p2p state-sync, so at least after state-syncing with KSYNC the node can be started normally, for block-sync however the node still panics which is an open issue.