feat: install the package with makepkg and run a command#33
Merged
KSXGitHub merged 3 commits intoKSXGitHub:masterfrom Mar 18, 2023
Merged
feat: install the package with makepkg and run a command#33KSXGitHub merged 3 commits intoKSXGitHub:masterfrom
KSXGitHub merged 3 commits intoKSXGitHub:masterfrom
Conversation
- add base-devel package which is required to do makepkg in many packages - use yay-bin to install dependencies - makepkg -si to install the package - run command to make sure the installed package works well
KSXGitHub
reviewed
Mar 17, 2023
build.sh
Outdated
Comment on lines
+98
to
+100
| git clone https://aur.archlinux.org/yay-bin.git && cd yay-bin && makepkg -si --noconfirm | ||
| cd /tmp/local-repo/ | ||
| grep -E 'depends' .SRCINFO | cut -f 3 -d ' '| sed -e 's/://' | xargs yay -S --noconfirm |
Owner
There was a problem hiding this comment.
Why is yay necessary? Why can't you execute makepkg -si on the current PKGBUILD directly?
Contributor
Author
There was a problem hiding this comment.
yay is used to install dependencies. Pacman cannot resolve dependencies found only in the AUR.
Owner
|
I am reluctant to merge this PR in this current form for the following reasons:
My suggestions:
|
…b#33 (comment) - no extra package is installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a feature to run a command after installing the package, which can be used to make sure the package can be installed and a command in the package works.