Merged
Conversation
The input sets the command-line flags provided to `makepkg` when trying to build the package (if the `test` option is enabled). The input is optional and its default value is the same as before introducing this input.
This is needed to be able to install packages with makepkg
KSXGitHub
requested changes
Nov 14, 2022
Owner
|
After you resolve my requests, can you test |
KSXGitHub
requested changes
Nov 14, 2022
KSXGitHub
approved these changes
Nov 14, 2022
Owner
|
Can you try |
Contributor
Author
|
Here is a successful run from a few minutes ago: https://github.com/fuljo/rofi-vscode-mode/actions/runs/3463753986 I used the |
Owner
|
v2.6.0 is released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really enjoyed the
testoption to check that the package could be succesfully built withmakepkg. The only flaw for me is that its command line flags are fixed:github-actions-deploy-aur/build.sh
Lines 82 to 87 in 325b53d
Changes
This PR adds a new input called
test_flagswhich sets the command line flags formakepkg.Its default value falls back to the old behavior, so there are no regression problems.
Furthermore, it makes the
builderuser a sudoer so it is able to install the dependencies.Example
I use it in this workflow where I need to install dependencies in order to build the package, and I also check that it installs successfully. Here is the interesting snippet:
You can see a succesful run of my fork here.