Fixes #3005 - now safe to use a setsuffix of a locked thing#3010
Merged
Dunbaratu merged 1 commit intoKSP-KOS:developfrom Feb 13, 2022
Merged
Fixes #3005 - now safe to use a setsuffix of a locked thing#3010Dunbaratu merged 1 commit intoKSP-KOS:developfrom
Dunbaratu merged 1 commit intoKSP-KOS:developfrom
Conversation
Fixes KSP-KOS#3005 - The discussion of the problem is long, see the issue KSP-KOS#3005. There was logic in the compiler that handled this situation: When in the context of compiling the lefthand side of a SET assignment, if that lefthand side is a function name, it should suppress the "invoke even when no parentheses are present" logic, like so: ``` set x to { return 1. }. // x is now a delegate function. print x. // Should call x() the function, even with the () missing. set x to 3. // Should NOT call x() when replacing x with a 3. ``` The problem was that this same logic that tries to handle that was partly firing off when the 'x' in question was followed by a suffix, when that should not be happening in that case: ``` set x to { return ship. }. set x:name to "hello". // Here x() DOES need to be called, to return // SHIP, which then gets its suffix :name set. ``` It was partially skipping half the work of setting up for the function call because it failed to realize one was coming. The part it skipped was the part that inserts the KOSArgMarker on the stack before the call happens.
kna27
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3005 - The discussion of the problem is long, see the issue #3005.
There was logic in the compiler that handled this situation:
When in the context of compiling the lefthand side of a SET assignment,
if that lefthand side is a function name, it should suppress the "invoke
even when no parentheses are present" logic, like so:
The problem was that this same logic that tries to handle that was
partly firing off when the 'x' in question was followed by a suffix,
when that should not be happening in that case:
It was partially skipping half the work of setting up for the function
call because it failed to realize one was coming. The part it skipped
was the part that inserts the KOSArgMarker on the stack before the call
happens.