Fixes #3002 ModuleCargoPart breaks PAW.#3003
Merged
Dunbaratu merged 1 commit intoKSP-KOS:developfrom Aug 19, 2021
Merged
Conversation
The fix was to only apply the ModuleCargoPart if the KSP version is high enough to be safe, using ModuleManager to do it. Note that ModuleManager still doesn't have a KSP version check filter, so I had to indirectly check the version by looking to see if a known part definition exists for a part that didn't exist prior to KSP 1.11.x. That's an ugly kludge, but it does seem to be what all the other modders who ran into this same problem did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3002
The fix was to only apply the ModuleCargoPart if the KSP version
is high enough to be safe, using ModuleManager to do it.
Note that ModuleManager still doesn't have a KSP version check filter,
so I had to indirectly check the version by looking to see if a known part
definition exists for a part that didn't exist prior to KSP 1.11.x.
That's an ugly kludge, but it does seem to be what all the other
modders who ran into this same problem did.