Culls out RCS thruster transforms for other part variants#2923
Merged
Dunbaratu merged 1 commit intoKSP-KOS:developfrom Apr 14, 2021
Merged
Culls out RCS thruster transforms for other part variants#2923Dunbaratu merged 1 commit intoKSP-KOS:developfrom
Dunbaratu merged 1 commit intoKSP-KOS:developfrom
Conversation
Fixes KSP-KOS#2912. The problem only exists in KSP 1.11 and up. In KSP 1.10.x and earlier, it was working. The problem was caused by the introduction of RCS part variants that came with KSP 1.11.x. Restock happened to exacerbate the problem because it has more part variants, but even the part variants that come with stock are enough to trigger the problem. The problem is that kOS's replacement for GetPotentialTorque() was adding up the superset of all the part variants' thruster nozzles, not just the nozzles that actually exist in the current part variant. You'd think that KSP would cull out the nozzles for other part variants when it builds the ModuleRCS.thrusterTransforms list, but it doesn't seem to do that, so we have to cull them ourselves when iterating over that list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2912.
The problem only exists in KSP 1.11 and up. In KSP 1.10.x and
earlier, it was working.
The problem was caused by the introduction of RCS part variants
that came with KSP 1.11.x. Restock happened to exacerbate the
problem because it has more part variants, but even the part
variants that come with stock are enough to trigger the problem.
The problem is that kOS's replacement for GetPotentialTorque()
was adding up the superset of all the part variants' thruster
nozzles, not just the nozzles that actually exist in the current
part variant. You'd think that KSP would cull out the nozzles
for other part variants when it builds the
ModuleRCS.thrusterTransforms list, but it doesn't seem to do that,
so we have to cull them ourselves when iterating over that list.