Conversation
Can work as a solution to KSP-KOS#2889, KSP-KOS#145
|
I don't think it does everything desired by those issues, but it is a fine idea to have this. Reading when I think we can just move the increment line from CPU.cs to just before, rather than just after, the ExecuteInstruction and it won't mess anything up. It would make the result of this easier to nail down. i.e. currently it does this on line 1505 of CPU.cs: and it could be changed to this without introducing a problem, I think: This would mean that semantically "InstructionsThisUpdate" is now counting how many instructions have happened including the current one, when before it was counting how many instructions have happened excluding the current one. |
Can work as a solution to #2889, #145