Fixes #2767 with two time types#2837
Merged
Dunbaratu merged 2 commits intoKSP-KOS:developfrom Jan 15, 2021
Merged
Conversation
This was referenced Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2627
I finally decided to implement the two types of time even though I didn't really like doing it. Partly it just feels like a lot of work just to cover the conversion-that-isn't-really-a-conversion between the two, and the rules of operatator overloading between them. I miss Unix timestamps. So much simpler. Anyway, it's done and here's the PR for it.
(This includes a new file called TimeSpan.cs and renamed an old file called Timespan.cs (capitalization differs). I hope this doesn't confuse github on Windows vs Linux systems (case sensitivity in filenames).)