Fixes #2817 with sub-branch searches.#2821
Merged
Dunbaratu merged 1 commit intoKSP-KOS:developfrom Dec 9, 2020
Merged
Conversation
To do this I moved the searching code into PartValue, and then made the existing Vessel searches into just special cases of the Part search in which the starting part is the vessel's root part. Thus they are both served by the same code. On an unrelated note this also includes changes to .csproj files to bring kOS up to .Net 4.5. This isn't part of the fix, but my dev environment is that way now so I can compile against my own ClickThroughBlocker DLL and it's too hard to keep pulling that part out of my PRs so I'll just go ahead and update the main repo to that when this merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2817
To do this I moved the searching code into PartValue,
and then made the existing Vessel searches into just special cases
of the Part search in which the starting part is the vessel's root part.
Thus they are both served by the same code.
On an unrelated note this also includes changes to .csproj files
to bring kOS up to .Net 4.5. This isn't part of the fix, but
my dev environment is that way now so I can compile against my own
ClickThroughBlocker DLL and it's too hard to keep pulling that part
out of my PRs so I'll just go ahead and update the main repo to that
when this merges.