Merged
Conversation
Also did a better job dealing with negative torque vectors, but the big fix is that a typo led to valid syntax that was making it skip the zero-th RCS thruster in every RCS part.
When I made my own homemade ModuleReactionWheel torque calc (to add the check for authority limiter slider), doing so ended up removing the stock check to see if the wheel is disabled altogether. This puts that check back.
Member
Author
|
This should have also closed issue #2807 about torque wheel slider being ignored. The homemade GetPotentialTorque() handles this as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2814 - had to make our own homemade replacement for GetPotentialTorque() in the case of RCS parts because the stock one is so very broken.
This starts from work other KSP modders did who also realized the stock ModuleRCS.GetPotentialTorque() is so wrong as to be impossible to just 'patch up', and wrote their own.