Put max fontsize in one place, and made it 48#2794
Merged
Dunbaratu merged 1 commit intoKSP-KOS:developfrom Oct 26, 2020
Merged
Conversation
Fixes KSP-KOS#2711 While I was at it, I moved all the mentions of font min and max size to one place to use the same constant everywhere to fix the way the mod disagreed with itself about the setting.
Dunbaratu
commented
Oct 26, 2020
| AddConfigKey(PropId.TerminalDefaultWidth, new ConfigKey("TerminalDefaultWidth", "DEFAULTWIDTH", "Initial Terminal:WIDTH when a terminal is first opened", 50, 15, 255, typeof(int))); | ||
| AddConfigKey(PropId.TerminalDefaultHeight, new ConfigKey("TerminalDefaultHeight", "DEFAULTHEIGHT", "Initial Terminal:HEIGHT when a terminal is first opened", 36, 3, 160, typeof(int))); | ||
| AddConfigKey(PropId.SuppressAutopilot, new ConfigKey("SuppressAutopilot", "SUPPRESSAUTOPILOT", "Suppress all kOS autopiloting for emergency manual control", false, false, true, typeof(bool))); | ||
| AddConfigKey(PropId.EnableTelnet, |
Member
Author
There was a problem hiding this comment.
The git diff for these next few lines makes it look like I made a lot of changes, but mostly I just split up the very long lines into multiple lines, except for the change involving TerminalStruct.MAXCHARSIZE - those were real.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2711
While I was at it, I moved all the mentions of
font min and max size to one place to use the
same constant everywhere to fix the way the
mod disagreed with itself about the setting.