Fixes #2373 with new atmosphere data.#2557
Merged
Dunbaratu merged 2 commits intoKSP-KOS:developfrom Jul 18, 2019
Merged
Conversation
While I was at it, I also edited a few lines in the constant documentation that needed cleaning up, since I was in there an noticed them. There is an API call from KSP called CelestialBody.GetFullTemperature(Vector3d position), but as far as I can tell it seems totally broken, or at least is in a weird reference frame I don't know about. So I gave up on supporting that, since I don't seem to be able to make it work (also, other KSP mods seem to have written their own replacement for this call as well, indicating that they found it didn't work for them either.)
(I didn't notice until I closed down the IDE and it said there was one file unsaved.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2373
While I was at it, I also edited a few lines in the
constant documentation that needed cleaning up,
since I was in there an noticed them.
There is an API call from KSP called
CelestialBody.GetFullTemperature(Vector3d position),
but as far as I can tell it seems totally broken, or
at least is in a weird reference frame I don't know about.
So I gave up on supporting that, since I don't seem
to be able to make it work (also, other KSP mods seem
to have written their own replacement for this call as
well, indicating that they found it didn't work for them
either.)