Fixes #18 by Dunbaratu · Pull Request #2549 · KSP-KOS/KOS

Dunbaratu · 2019-06-15T20:51:52Z

This has been sitting a long time, but was stuck on not
liking any syntax choice - then it came up in Discord
again and people seemed to like this, so I finally did
it:

CHOOSE expr1 IF bool_expr ELSE expr2.

This has been sitting a long time, but was stuck on not liking any syntax choice - then it came up in Discord again and people seemed to like this, so I finally did it: CHOOSE expr1 IF bool_expr ELSE expr2.

teleksterling · 2019-06-17T00:42:03Z

kerboscript_tests/ternary.ks

+print "  Next 2 lines should be 'B':".
+print "  " + (choose "A" if (choose x if a=2 else y) else "B").
+print "  " + (choose "A" if choose x if a=2 else y else "B"). // same without parens should work.
+


Suggested change

+

+print "Third nesting case - nesting choose in the first term.".

+print " Next two lines should be 'A'.".

+print " " + (choose (choose "A" if true else "B") if true else "C").

+print " " + (choose choose "A" if true else "B" if true else "C"). // same without parens should work.

+print " Next two lines should be 'B'.".

+print " " + (choose (choose "A" if false else "B") if true else "C").

+print " " + (choose choose "A" if false else "B" if true else "C"). // same without parens should work.

+print " Next four lines should be 'C'.".

+print " " + (choose (choose "A" if true else "B") if false else "C").

+print " " + (choose choose "A" if true else "B" if false else "C"). // same without parens should work.

+print " " + (choose (choose "A" if false else "B") if false else "C"). // result of inner test should affect result

+print " " + (choose choose "A" if false else "B" if false else "C"). // same without parens should work.

+

+

Fixes #18

b9b1bd5

This has been sitting a long time, but was stuck on not liking any syntax choice - then it came up in Discord again and people seemed to like this, so I finally did it: CHOOSE expr1 IF bool_expr ELSE expr2.

Dunbaratu added the enhancement Something new (not a bug fix) is being requested label Jun 15, 2019

jonnyboyC mentioned this pull request Jun 15, 2019

[Feature] Support new choose expression jonnyboyC/kos-language-server#59

Closed

teleksterling reviewed Jun 17, 2019

View reviewed changes

Dunbaratu merged commit b9b1bd5 into KSP-KOS:develop Jun 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #18#2549

Fixes #18#2549
Dunbaratu merged 1 commit intoKSP-KOS:developfrom
Dunbaratu:ternary_operator

Dunbaratu commented Jun 15, 2019

Uh oh!

teleksterling Jun 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

++
++print "Third nesting case - nesting choose in the first term.".
++print " Next two lines should be 'A'.".
++print "  " + (choose (choose "A" if true else "B") if true else "C").
++print "  " + (choose choose "A" if true else "B" if true else "C"). // same without parens should work.
++print " Next two lines should be 'B'.".
++print "  " + (choose (choose "A" if false else "B") if true else "C").
++print "  " + (choose choose "A" if false else "B" if true else "C"). // same without parens should work.
++print " Next four lines should be 'C'.".
++print "  " + (choose (choose "A" if true else "B") if false else "C").
++print "  " + (choose choose "A" if true else "B" if false else "C"). // same without parens should work.
++print "  " + (choose (choose "A" if false else "B") if false else "C"). // result of inner test should affect result
++print "  " + (choose choose "A" if false else "B" if false else "C"). // same without parens should work.
++
++

Conversation

Dunbaratu commented Jun 15, 2019

Uh oh!

teleksterling Jun 17, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants