Fixes #2272 Multiple triggers.#2275
Merged
erendrake merged 2 commits intoKSP-KOS:developfrom Jul 27, 2018
Merged
Conversation
The previous value for an ON (to detect the it has changed) is still suing a global value determined at runtime so it can't store more than one of them, which means multiple ON's from the same line of code don't work right. WHENs are working though.
On triggers' previous values are now tracked separately merely by taking advantage of the local scoping that was made available several months ago for triggers. We just weren't using it because we still had the old code that tried using the Global instead of Local storage Opcodes in the trigger's boilerplate code blocks that tracked the previous value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2272 (not yet - Do NOT MERGE yet)
The previous value for an ON (to detect the it has
changed) is still suing a global value determined
at runtime so it can't store more than one of them,
which means multiple ON's from the same line of code
don't work right. WHENs are working though.