Skip to content

Fixes #2272 Multiple triggers.#2275

Merged
erendrake merged 2 commits intoKSP-KOS:developfrom
Dunbaratu:fixes_2272_allow_multiple_trigger_instances
Jul 27, 2018
Merged

Fixes #2272 Multiple triggers.#2275
erendrake merged 2 commits intoKSP-KOS:developfrom
Dunbaratu:fixes_2272_allow_multiple_trigger_instances

Conversation

@Dunbaratu
Copy link
Member

Fixes #2272 (not yet - Do NOT MERGE yet)

The previous value for an ON (to detect the it has
changed) is still suing a global value determined
at runtime so it can't store more than one of them,
which means multiple ON's from the same line of code
don't work right. WHENs are working though.

The previous value for an ON (to detect the it has
changed) is still suing a global value determined
at runtime so it can't store more than one of them,
which means multiple ON's from the same line of code
don't work right.  WHENs are working though.
@Dunbaratu Dunbaratu added the Not Ready Author is warning Reveiwer not to merge this PR yet. More edits are expected. label Apr 16, 2018
On triggers' previous values are now tracked separately
merely by taking advantage of the local scoping
that was made available several months ago for triggers.

We just weren't using it because we still had the old code
that tried using the Global instead of Local storage Opcodes
in the trigger's boilerplate code blocks that tracked the
previous value.
@Dunbaratu Dunbaratu added bug Weird outcome is probably not what the mod programmer expected. and removed Not Ready Author is warning Reveiwer not to merge this PR yet. More edits are expected. labels Apr 21, 2018
@Dunbaratu Dunbaratu requested a review from hvacengi April 21, 2018 05:52
@Dunbaratu Dunbaratu changed the title Fixes #2272 (not yet) Multiple triggers, but ON's prev val still global. Fixes #2272 Multiple triggers. Apr 22, 2018
@Dunbaratu Dunbaratu added this to the v1.1.6.0 milestone Jul 22, 2018
@erendrake erendrake merged commit 4042232 into KSP-KOS:develop Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Weird outcome is probably not what the mod programmer expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants