triggers from delegate with bound args - fixes #2236#2238
Conversation
|
Would it be possible to add .editorconfig maybe like this? or whatever you prefer (I prefer tabs - ts=4, or two spaces. Four spaces are a bit odd, but use whatever you like, that .editorconfig should make it easier for anybody using VS or anything supporting it and I made it according to what the current style appears to be). ..and add |
|
I'm about to test this PR and probably merge it, but as for the visual studio settings, that would be a better question for @hvacengi than me. I don't use Visual Studio so I can't really verify what those settings do. But one thing I am slightly wary of: the terminology "ts=4" implies you might be using vim. Is this true? I use it too sometimes. If you are using vim, I would strongly recommend indenting with sw=4 rather than ts=4, (leaving it at ts=8, the standard default), and setting |
|
This PR seems like a good solution. Good work, @firda-cze. Ideally, it would probably be better to fix But given the limitation that |
|
Merged, but first I had to strip some hard tab chars and replace them with equivalent spaces to match our standard. The assumption that you are viewing the ascii text in a system that uses 4-char tabs isn't something you can always do in every tool you might use with the source code (especially as 8 char tabs is the more common standard). If someone else views the code in a viewer with different tab sizes than you used, it looks all wrong to them as the tabbed lines don't match up with the spaced lines. That's why tabs have to be a sort of all-or-nothing affair in the source code from day 1. Either you have to say it's wrong to use tabs, or say it's wrong to use spaces. You can't really mix and match the two styles in the same project. |
|
@firda-cze I delayed merging this a while because I was investigating a problem with delegates that showed up when I ran |
|
@Dunbaratu I also use vim, but you can add And debate about what is best can be endless and pointless, so, I will only state my own opinion: four tabs are best for coding, it is just faster for navigation, easier and faster editing. But I can understand that some editors have problems with it, so, I accept two spaces as reasonable alternative (those two are mainstream, ts=4 or sw=2). Four spaces are cumbersome for me, but I can use it if you add the |
|
@Dunbaratu The problem with |
I have chosen to fix
CPU.AddTriggerbecause this seems to be the point whereUserDelegategets converted toEntryPointandPreBoundArgswere lost. Now passes the test with simple button:fixes #2236
P.S.: I seem to have different formatting options. Would it be possible to add
.editorconfig?