-
Notifications
You must be signed in to change notification settings - Fork 241
Closed
Labels
bugWeird outcome is probably not what the mod programmer expected.Weird outcome is probably not what the mod programmer expected.duplicateWill close because another PR or issue is the same. (please link to it when using this label)Will close because another PR or issue is the same. (please link to it when using this label)
Description
I was noticing my landing script thought my vessel was over 18 meters tall, when clearly it was only about 3 or 4 meters high.
Diagnosing this, it turns out that engines return wrong bounds when the Waterfall mod is installed. It seems to be that the exhaust plume is being counted as part of the engine's dimensions (even when the throttle is zero so the engine isn't firing).
To reproduce:
- Have these two mods installed: Waterfall, and Stock Waterfall Configs.
- Make a ship that uses a Terrier engine (may happen with other engines too, but this is the one I noticed it with).
for p in ship:parts { print "bounds for " + p + " is " + p:bounds. }- Note the
:RELMINfor the Terrier engine part has a negative Z of about 18.1 meters.
To fix this we should probably have some better logic within bounds calculations to know which components are "not physical" and therefore should not count. Something that's purely visual with no colliders probably shouldn't count.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugWeird outcome is probably not what the mod programmer expected.Weird outcome is probably not what the mod programmer expected.duplicateWill close because another PR or issue is the same. (please link to it when using this label)Will close because another PR or issue is the same. (please link to it when using this label)