Skip to content

Add D symbol demangling#260

Closed
BorisCarvajal wants to merge 1 commit intoKDAB:masterfrom
BorisCarvajal:ddemangle
Closed

Add D symbol demangling#260
BorisCarvajal wants to merge 1 commit intoKDAB:masterfrom
BorisCarvajal:ddemangle

Conversation

@BorisCarvajal
Copy link

@BorisCarvajal BorisCarvajal commented Oct 12, 2020

I copied many lines from Rust commit, I hope it works.

Issue #242

target_compile_definitions(hotspot-perfparser PRIVATE HAVE_RUSTC_DEMANGLE=1)
endif()

set(D_DEMANGLE_LIBRARY "" CACHE STRING "Path to the libddemangle.so library.")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can one find that library? does it not have an include library?

please add more details to the commit message

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it not have an include library?

I can make a D function accessible from C++ using extern (C++) on D side, just need to link.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please do that. ideally make it a separate github project similar to the rustc demangle library. ship a header there and also document how one would build the .so in the first place then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping? any update on this?

@milianw
Copy link
Collaborator

milianw commented Jan 6, 2021

if anyone else would like to work on this, please reference #269 and implement D demangling in a similar fashion, then nothing should be needed on our side (except for packaging purposes)

@milianw
Copy link
Collaborator

milianw commented Dec 14, 2021

we got a different way implemented now thanks to @lievenhey , I'm closing this approach here now then

@milianw milianw closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants