Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Julien-R44/fast-ssh
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.1
Choose a base ref
...
head repository: Julien-R44/fast-ssh
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.2
Choose a head ref
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on Apr 23, 2022

  1. chore: add funding

    Julien-R44 authored Apr 23, 2022
    Configuration menu
    Copy the full SHA
    de145d7 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Fix ambiguous call to constraints.as_ref() (#22)

    If `fast-ssh` is built with an up-to-date version of `rustc`,
    the compiler complains about `constraints.as_ref()` being ambiguous,
    demanding the types involved in the `.constraints()` call be clarified
    with a `::<&[Constraint]>` turbofish annotation:
    
    ```
    Compiling fast-ssh v0.3.1 (/build/source)
    error[E0283]: type annotations needed
      --> src/layout.rs:60:10
       |
    60 |         .constraints(constraints.as_ref())
       |          ^^^^^^^^^^^             ------ type must be known at this point
       |          |
       |          cannot infer type of the type parameter `C` declared on the method `constraints`
       |
       = note: multiple `impl`s satisfying `Vec<Constraint>: AsRef<_>` found in the `alloc` crate:
               - impl<T, A> AsRef<Vec<T, A>> for Vec<T, A>
                 where A: Allocator;
               - impl<T, A> AsRef<[T]> for Vec<T, A>
                 where A: Allocator;
    help: consider specifying the generic argument
       |
    60 |         .constraints::<&T>(constraints.as_ref())
       |                     ++++++
    
    For more information about this error, try `rustc --explain E0283`.
    error: could not compile `fast-ssh` (bin "fast-ssh") due to previous error
    ```
    
    Luckily, if we use `constraints.as_slice()` instead, the types
    involved are still apparent to the compiler, and the resulting
    code still remains about as readable as before.
    mfrischknecht authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    0d81887 View commit details
    Browse the repository at this point in the history
  2. chore: update dependencies

    Julien-R44 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    6814353 View commit details
    Browse the repository at this point in the history
  3. style: fix lint errors

    Julien-R44 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    5618dd0 View commit details
    Browse the repository at this point in the history
  4. chore: release 0.3.2

    Julien-R44 committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    7e62107 View commit details
    Browse the repository at this point in the history
Loading