Serde as a feature flag#3
Merged
Julien-R44 merged 2 commits intoJulien-R44:mainfrom Nov 14, 2021
tinywombat765:serde-feature
Merged
Serde as a feature flag#3Julien-R44 merged 2 commits intoJulien-R44:mainfrom tinywombat765:serde-feature
Julien-R44 merged 2 commits intoJulien-R44:mainfrom
tinywombat765:serde-feature
Conversation
added 2 commits
November 14, 2021 03:26
Signed-off-by: Ben Aaron Goldberg <ben@benaaron.dev>
Signed-off-by: Ben Aaron Goldberg <ben@benaaron.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you make main an example like I suggested in #1, you can also make serde an optional dependency that can be turned on with a feature flag. this further reduces the number of dependencies.