Eliminate type-piracy in string#549
Merged
quinnj merged 1 commit intoJuliaWeb:masterfrom Jun 30, 2020
timholy:teh/stringify
Merged
Eliminate type-piracy in string#549quinnj merged 1 commit intoJuliaWeb:masterfrom timholy:teh/stringify
string#549quinnj merged 1 commit intoJuliaWeb:masterfrom
timholy:teh/stringify
Conversation
Overriding behavior for a particular eltype of a container is piracy against the container.
This was referenced Jun 27, 2020
quinnj
approved these changes
Jun 30, 2020
Member
quinnj
left a comment
There was a problem hiding this comment.
No, this is basically an "internal" only method, so definitely a good change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overriding behavior for a particular eltype of a container is piracy against the container. I have no particular attachment to this particular solution; perhaps you want to define a
CookieRequeststruct and then overloadBase.show? Anyway, this seemed like the easiest approach, but I do not know how this package interacts with a wider ecosystem so this change could, for all I know, be breaking.Deleting this method (or replacing it with a private one) eliminates approximately 250 method invalidations, mostly from
Base.show_unquotedwhich rampantly callsstring(::String, args...). It's a small enough effect that it's a little difficult to measure, but this change seems to shave about 5% off TTFP.