Revert "Drop support for julia 1.0-1.3 (#221)"#224
Conversation
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
===========================================
- Coverage 88.33% 76.17% -12.17%
===========================================
Files 10 11 +1
Lines 506 768 +262
===========================================
+ Hits 447 585 +138
- Misses 59 183 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
As already expected, `Test = "1.0" fails on julia 1.0-1.3 (log) |
43100ce to
7032263
Compare
|
|
|
@fingolfin What do you think? Should we enable compatibility with julia 1.0 again (by merging this PR)? If yes, I should look through the changes in detail, because there were a few conflicts when reverting stuff. If you approve this, could you change the required CI jobs back to needing 1.0-1.3 for ubuntu, 1.0 for windows and macOS, and instead remove 1.4 for windows and macOS? |
|
I believe it is important that the code written for Julia 1.0 works with the latest versions of Julia and some packages. On the other hand, I think it is rare for users who do not upgrade their Julia version to only upgrade the version of Aqua.jl, so I feel there is no need to actively support Julia versions prior to 1.6 (LTS). Sorry for repeating my previous comment (#216 (comment)), but I feel it would be nice to reduce the costs to maintain this package. |
fingolfin
left a comment
There was a problem hiding this comment.
Honestly I don't think support for the older Julia versions is worth the hassle.
However, if you are willing to take care of the burden, I certainly won't object! In the worst case, we could still re-remove it later.
As such, I think you should make the final decision, Lars. I won't complain either way :-)
Test compat for julia 1.0-1.37032263 to
f2094d3
Compare
|
I would like to continue with this PR. As said, we can drop support again at any point in time, if maintaining becomes too much of a hassle.
@fingolfin could you please adapt the "required" CI jobs as listed here? And feel free to merge once that is done. |
No description provided.