Skip to content

Add option to test_deps_compat to test extras and weakdeps#200

Merged
lgoettgens merged 3 commits intoJuliaTesting:masterfrom
lgoettgens:lg/compat-extras-weakdeps
Oct 24, 2023
Merged

Add option to test_deps_compat to test extras and weakdeps#200
lgoettgens merged 3 commits intoJuliaTesting:masterfrom
lgoettgens:lg/compat-extras-weakdeps

Conversation

@lgoettgens
Copy link
Copy Markdown
Collaborator

@lgoettgens lgoettgens commented Sep 27, 2023

Resolves #178 and adds the same for weakdeps as well.

The tests are disabled by default, until maybe the next breaking release (see #202).

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2023

Codecov Report

Merging #200 (64e67f9) into master (01c98d9) will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   76.80%   76.81%   +0.01%     
==========================================
  Files          11       11              
  Lines         763      772       +9     
==========================================
+ Hits          586      593       +7     
- Misses        177      179       +2     
Flag Coverage Δ
unittests 76.81% <81.81%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/deps_compat.jl 71.05% <81.81%> (+2.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgoettgens lgoettgens force-pushed the lg/compat-extras-weakdeps branch from bc4d5cd to cd0f938 Compare September 27, 2023 22:35
@lgoettgens lgoettgens added enhancement New feature or request test: deps compat labels Sep 27, 2023
@lgoettgens lgoettgens marked this pull request as ready for review September 27, 2023 22:40
@gdalle
Copy link
Copy Markdown
Contributor

gdalle commented Oct 12, 2023

This is a good idea!

@lgoettgens lgoettgens added this to the 0.7.x milestone Oct 16, 2023
@lgoettgens
Copy link
Copy Markdown
Collaborator Author

I'll now merge this although @fingolfin's approval is still missing (he said he currently doesn't have time to review it) to get forward with the 0.8 release.

@lgoettgens lgoettgens force-pushed the lg/compat-extras-weakdeps branch from 3e4ceb2 to 64e67f9 Compare October 24, 2023 08:04
@lgoettgens lgoettgens merged commit ae59733 into JuliaTesting:master Oct 24, 2023
@lgoettgens lgoettgens deleted the lg/compat-extras-weakdeps branch October 24, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request test: deps compat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option for test_deps_compat to check extra/test deps have compat

2 participants