Turn test_persistent_tasks on by default

lgoettgens · lgoettgens · commit 77f7fd7810e4 · 2023-10-24T16:27:14.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,8 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Two additions check whether packages might block precompilation on Julia 1.10 or higher:
-  + `test_persistent_tasks` tests whether "your" package can safely be used as a dependency for downstream packages. This test is disabled for the default testsuite, but you can opt-in by supplying `persistent_tasks=true` to `test_all`.
+- Two additions check whether packages might block precompilation on Julia 1.10 or higher: ([#174](https://github.com/JuliaTesting/Aqua.jl/pull/174))
+  + `test_persistent_tasks` tests whether "your" package can safely be used as a dependency for downstream packages. This test is enabled for the default testsuite, but you can opt-out by supplying `persistent_tasks=false` to `test_all`. [BREAKING]
   + `find_persistent_tasks_deps` is useful if "your" package hangs upon precompilation: it runs `test_persistent_tasks` on all the things you depend on, and may help isolate the culprit(s).
 
 ### Changed
diff --git a/src/Aqua.jl b/src/Aqua.jl
@@ -52,7 +52,7 @@ passed to `\$x` to specify the keyword arguments for `test_\$x`.
 - `deps_compat = true`
 - `project_toml_formatting = true`
 - `piracy = true`
-- `persistent_tasks = false` (will become `true` in the next breaking release)
+- `persistent_tasks = true`
 """
 function test_all(
     testtarget::Module;
@@ -64,7 +64,7 @@ function test_all(
     deps_compat = true,
     project_toml_formatting = true,
     piracy = true,
-    persistent_tasks = false,
+    persistent_tasks = true,
 )
     @testset "Method ambiguity" begin
         if ambiguities !== false
diff --git a/test/test_smoke.jl b/test/test_smoke.jl
@@ -16,7 +16,7 @@ Aqua.test_all(
     deps_compat = (; check_extras = true, check_weakdeps = true),
     project_toml_formatting = false,
     piracy = false,
-    persistent_tasks = true,
+    persistent_tasks = false,
 )
 
 end  # module

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ Aqua.test_all(`
`16`	`16`	`deps_compat = (; check_extras = true, check_weakdeps = true),`
`17`	`17`	`project_toml_formatting = false,`
`18`	`18`	`piracy = false,`
`19`		`- persistent_tasks = true,`
	`19`	`+ persistent_tasks = false,`
`20`	`20`	`)`
`21`	`21`
`22`	`22`	`end # module`