Skip to content

CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; run the ambiguous testgroup in Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip#472

Closed
DilumAluthge wants to merge 2 commits intomainfrom
dpa/aqua-compat-buildkite
Closed

CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; run the ambiguous testgroup in Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip#472
DilumAluthge wants to merge 2 commits intomainfrom
dpa/aqua-compat-buildkite

Conversation

@DilumAluthge
Copy link
Copy Markdown
Member

@DilumAluthge DilumAluthge commented Nov 15, 2023

Reverts much of #471

This PR introduces a framework for installing test deps during stdlib CI in a way that respects [compat] entries. We can likely use this same framework in other stdlib repos.

@DilumAluthge DilumAluthge changed the title CI: Respect [compat] entries for test-only deps when running in Bas… CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI Nov 15, 2023
@DilumAluthge DilumAluthge force-pushed the dpa/aqua-compat-buildkite branch from 76d916a to f90945d Compare November 15, 2023 22:46
@DilumAluthge DilumAluthge changed the title CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip Nov 15, 2023
@DilumAluthge DilumAluthge changed the title CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; run the ambiguous testgroup in Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip Nov 15, 2023
…e Julia's Buildkite CI; run the `ambiguous` testgroup in Buildkite CI; mark `Aqua.test_project_toml_formatting` as `@test_skip`
@DilumAluthge DilumAluthge force-pushed the dpa/aqua-compat-buildkite branch from 9f12428 to 3d9eadb Compare November 16, 2023 00:12
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (f154de2) to head (879a806).
Report is 70 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   85.64%   85.69%   +0.04%     
==========================================
  Files          13       13              
  Lines        8861     8861              
==========================================
+ Hits         7589     7593       +4     
+ Misses       1272     1268       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah requested a review from fredrikekre January 9, 2024 05:10
@ViralBShah
Copy link
Copy Markdown
Member

Anything further to be done here?

@ViralBShah ViralBShah closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants