Fix unnecessary allocations in distGauss!#96
Merged
Conversation
dehann
approved these changes
Oct 12, 2023
Member
dehann
left a comment
There was a problem hiding this comment.
Wow okay... would you mind trying === also?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was actually a performance bottleneck in IIF.
Also, note that
isX86Archis not used.Standard hex test:
Before:
3.699988 seconds (1.78 M allocations: 90.311 MiB, 1.34% gc time)
After:
2.668882 seconds (1.31 M allocations: 62.113 MiB, 0.94% gc time)