Skip to content

Fix mixture sampling and deconv for static arrays#1779

Merged
Affie merged 2 commits into23Q3/dev/parametricfrom
23Q4/fix/mix_deconv_sa
Oct 11, 2023
Merged

Fix mixture sampling and deconv for static arrays#1779
Affie merged 2 commits into23Q3/dev/parametricfrom
23Q4/fix/mix_deconv_sa

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Oct 11, 2023

No description provided.

@Affie Affie added this to the v0.34.2 milestone Oct 11, 2023
@Affie Affie self-assigned this Oct 11, 2023
Comment thread src/Factors/Mixture.jl
cf.factor.labels .= rand(cf.factor.diversity, N)
M = cf.manifold

# mixture needs to be refactored so let's make it worse :-)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're going to ditch .mechanics with Mixture refactor:

Comment thread src/entities/AliasScalarSampling.jl Outdated
Copy link
Copy Markdown
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see specific suggestions

Co-authored-by: Dehann Fourie <6412556+dehann@users.noreply.github.com>
@Affie Affie merged commit c58ae70 into 23Q3/dev/parametric Oct 11, 2023
@Affie Affie modified the milestones: v0.34.2, v0.35.0 Oct 12, 2023
@Affie Affie deleted the 23Q4/fix/mix_deconv_sa branch May 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants