Skip to content

Fix getPointType of Position{N}#1776

Merged
dehann merged 7 commits intomasterfrom
23Q3/fix/pospointtype
Oct 9, 2023
Merged

Fix getPointType of Position{N}#1776
dehann merged 7 commits intomasterfrom
23Q3/fix/pospointtype

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Sep 19, 2023

No description provided.

@Affie Affie added the bug fix label Sep 19, 2023
@Affie Affie added this to the v0.34.2 milestone Sep 19, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1776 (21cddbe) into master (ad00c3b) will increase coverage by 1.06%.
Report is 3 commits behind head on master.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
+ Coverage   74.16%   75.23%   +1.06%     
==========================================
  Files          81       82       +1     
  Lines        5869     5872       +3     
==========================================
+ Hits         4353     4418      +65     
+ Misses       1516     1454      -62     
Files Coverage Δ
src/Variables/DefaultVariables.jl 100.00% <100.00%> (ø)
src/entities/ExtFactors.jl 100.00% <ø> (ø)
src/manifolds/services/ManifoldSampling.jl 88.88% <100.00%> (ø)
src/parametric/services/ParametricCSMFunctions.jl 88.63% <100.00%> (ø)
src/services/GraphInit.jl 90.00% <ø> (ø)
src/services/GraphProductOperations.jl 90.62% <100.00%> (+3.52%) ⬆️
src/services/NumericalCalculations.jl 69.69% <100.00%> (+1.75%) ⬆️
src/manifolds/services/ManifoldsExtentions.jl 75.80% <0.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dehann
Copy link
Copy Markdown
Member

dehann commented Oct 9, 2023

FYI, @Affie , this PR and issues associated have been fixed and will merge

@dehann dehann merged commit 525602e into master Oct 9, 2023
@Affie Affie modified the milestones: v0.34.2, v0.35.0 Oct 17, 2023
@Affie Affie deleted the 23Q3/fix/pospointtype branch May 6, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants