Skip to content

Custom DFG errors #1147

Merged
Affie merged 8 commits intodevelopfrom
enh/custom_label_error
Jun 29, 2025
Merged

Custom DFG errors #1147
Affie merged 8 commits intodevelopfrom
enh/custom_label_error

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Jun 26, 2025

Standard errors and update functions that should throw them.

@Affie Affie added this to the v0.28.0 milestone Jun 26, 2025
@Affie Affie self-assigned this Jun 26, 2025
@Affie Affie requested a review from dehann June 26, 2025 16:31
@Affie Affie force-pushed the enh/custom_label_error branch from dd48d7e to 44659cf Compare June 26, 2025 16:36
Comment thread src/DataBlobs/services/BlobEntry.jl Outdated
Comment thread src/errors.jl Outdated
@Affie Affie modified the milestones: v0.28.0, v0.27.0 Jun 27, 2025
Comment thread src/errors.jl
@Affie Affie marked this pull request as ready for review June 27, 2025 11:02
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.42%. Comparing base (1b6116f) to head (c436ab3).
⚠️ Report is 39 commits behind head on develop.

Files with missing lines Patch % Lines
src/errors.jl 21.42% 11 Missing ⚠️
src/Deprecated.jl 0.00% 4 Missing ⚠️
src/GraphsDFG/services/GraphsDFG.jl 78.57% 3 Missing ⚠️
src/DataBlobs/services/BlobEntry.jl 75.00% 1 Missing ⚠️
src/services/AbstractDFG.jl 66.66% 1 Missing ⚠️
src/services/DFGVariable.jl 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1147      +/-   ##
===========================================
- Coverage    73.58%   73.42%   -0.17%     
===========================================
  Files           28       29       +1     
  Lines         2442     2457      +15     
===========================================
+ Hits          1797     1804       +7     
- Misses         645      653       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Affie Affie merged commit 89b1892 into develop Jun 29, 2025
4 of 6 checks passed
@Affie Affie deleted the enh/custom_label_error branch June 29, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants