Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
- Coverage 21.42% 0.00% -21.43%
==========================================
Files 50 49 -1
Lines 3010 2987 -23
==========================================
- Hits 645 0 -645
- Misses 2365 2987 +622
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
dehann
commented
Jul 26, 2022
Affie
reviewed
Jul 28, 2022
| ``` | ||
|
|
||
| The return type for `getSample` is unrestricted, and will be passed to the residual function "as-is". | ||
| The return type for `getSample` is unrestricted, and will be passed to the residual function "as-is", but must return values representing a tangent vector for `<:AbstractRelative` |
Member
There was a problem hiding this comment.
I think this might be the other way around, getSample on <:AbstractPrior must return a Point on manifold, on Relative, it is unrestricted, but we recommend a tangent vector TpM.
I'll try and find the issue where this was discussed.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Tangent on relative factors -- that's what the PR already has, no? "a tangent vector for <:AbstractRelative"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.