Skip to content

Commit 3866bcc

Browse files
authored
Merge pull request #968 from JuliaRobotics/23Q3/ext/weakdeps
fix test scatteralign
2 parents 4dd8627 + b546a92 commit 3866bcc

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

examples/dev/scalar/boxy.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ IIF will deal with partials,
6666
DevNotes
6767
- FIXME ongoing (2021Q2), see #1206, likely also #1010
6868
"""
69-
struct Point2Point2Northing{B <: IIF.SamplableBelief, T <: Tuple} <: IIF.AbstractRelativeMinimize
69+
struct Point2Point2Northing{B <: IIF.SamplableBelief, T <: Tuple} <: IIF.AbstractManifoldMinimize
7070
Z::B
7171
partial::T # which dimension the partial applies to
7272
end

ext/factors/ScanMatcherPose2.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ arp2 = ScanMatcherPose2(img1, img2, 2) # e.g. 2 meters/pixel
1919
2020
See also: [`overlayScanMatcher`](@ref)
2121
"""
22-
struct ScanMatcherPose2{T} <: IIF.AbstractRelativeMinimize
22+
struct ScanMatcherPose2{T} <: IIF.AbstractManifoldMinimize
2323
""" reference image for scan matching. """
2424
im1::Matrix{T}
2525
""" test image to scan match against the reference image. """

ext/factors/ScatterAlignPose.jl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ See also: [`ScatterAlignPose2`](@ref), [`ScatterAlignPose3`](@ref), [`overlaySca
4949
"""
5050
Base.@kwdef struct ScatterAlign{P,
5151
H1 <: Union{<:ManifoldKernelDensity, <:HeatmapGridDensity},
52-
H2 <: Union{<:ManifoldKernelDensity, <:HeatmapGridDensity} } <: IIF.AbstractRelativeMinimize
52+
H2 <: Union{<:ManifoldKernelDensity, <:HeatmapGridDensity} } <: IIF.AbstractManifoldMinimize
5353
""" reference image for scan matching. """
5454
cloud1::H1
5555
""" test image to scan match against the reference image. """
@@ -79,7 +79,7 @@ Specialization of [`ScatterAlign`](@ref) for [`Pose2`](@ref).
7979
8080
See also: [`ScatterAlignPose3`](@ref)
8181
"""
82-
struct ScatterAlignPose2 <: IIF.AbstractRelativeMinimize
82+
struct ScatterAlignPose2 <: IIF.AbstractManifoldMinimize
8383
align::ScatterAlign{Pose2,<:Any,<:Any}
8484
end
8585

@@ -92,7 +92,7 @@ Specialization of [`ScatterAlign`](@ref) for [`Pose3`](@ref).
9292
9393
See also: [`ScatterAlignPose2`](@ref)
9494
"""
95-
struct ScatterAlignPose3 <: IIF.AbstractRelativeMinimize
95+
struct ScatterAlignPose3 <: IIF.AbstractManifoldMinimize
9696
align::ScatterAlign{Pose3,<:Any,<:Any}
9797
end
9898

test/testScatterAlignPose2.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# test ScatterAlignPose2
22

3+
# using Revise
34
using Test
45
using Images
56
using Caesar

0 commit comments

Comments
 (0)