Skip to content

Update to the newest apriltag 3 library#34

Merged
Affie merged 11 commits intomasterfrom
update/apriltag3
Jan 29, 2019
Merged

Update to the newest apriltag 3 library#34
Affie merged 11 commits intomasterfrom
update/apriltag3

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Jan 9, 2019

No description provided.

-removed tag36h10
-removed tag36h7
-removed goodness
-removed refine_decode
-removed refine_pose
+add decode_sharpening
+new tag types
TODO new pose
@Affie Affie force-pushed the update/apriltag3 branch 2 times, most recently from 9df9159 to 867580c Compare January 9, 2019 14:40
@Affie
Copy link
Copy Markdown
Member Author

Affie commented Jan 10, 2019

Travis no longer stalls, but runs out of memmory

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 16, 2019

Codecov Report

Merging #34 into master will decrease coverage by 17.16%.
The diff coverage is 36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #34       +/-   ##
==========================================
- Coverage   95.07%   77.9%   -17.17%     
==========================================
  Files           4       4               
  Lines         325     421       +96     
==========================================
+ Hits          309     328       +19     
- Misses         16      93       +77
Impacted Files Coverage Δ
src/AprilTags.jl 100% <ø> (ø) ⬆️
src/wrapper.jl 39.02% <15.78%> (-14.83%) ⬇️
src/helpers.jl 78.1% <39.62%> (-20.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125b4e9...c063fa2. Read the comment docs.

@dehann
Copy link
Copy Markdown
Member

dehann commented Jan 18, 2019

dehann Is this the correct use of Project.toml?

Sorry I have not dug deeper into toml's yet. Looks like people are slowly migrating there but I'm a little behind on that front.

I like the idea of having examples work reliably. A lot of API features are stabilizing, so maybe a good time to review all the examples in Caesar/RoME.

@Affie Affie merged commit c198aba into master Jan 29, 2019
@Affie Affie deleted the update/apriltag3 branch March 19, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants