Conversation
Affie
commented
Sep 12, 2025
Comment on lines
+272
to
+277
| Distributions.variate_form(mkd::ManifoldKernelDensity) = Ndim(mkd) == 1 ? Univariate : Multivariate | ||
| function Random.rand(mkd::ManifoldKernelDensity) | ||
| return _rand(Distributions.variate_form(mkd), mkd) | ||
| end | ||
| _rand(::Type{Univariate}, mkd::ManifoldKernelDensity) = sample(mkd.belief, 1)[1][:][] | ||
| _rand(::Type{Multivariate}, mkd::ManifoldKernelDensity) = sample(mkd.belief, 1)[1][:] |
Member
Author
There was a problem hiding this comment.
Not type stable, but a step in the direction of standard rand following <: Sampleable
dehann
approved these changes
Sep 12, 2025
Member
There was a problem hiding this comment.
Do you know where the unstable type code is at? I don't see any forced abstracts -- all the arguments etc should resolve?
The closest one I noticed was the missing <: but assumed you just copied that from Distributions.jl as is, e.g. ::Type{<:Univariate}.
Member
Author
|
rand returns a vector or scalar. We can add Univariate/Multivariate to MKD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.