Add AbstractOptimizationResult
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for more seamless conversion between the result objects of different methods. To convert between two result types, the first result is converted to a Dict of field names to values, and then that dict is converted to the target result type. This assumes that all result types have a common set of field names, and for any field in a result that is not in that common set, a custom convert method must be defined that sets default values for those fields in the target result type.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
========================================
+ Coverage 88.5% 88.6% +0.2%
========================================
Files 19 20 +1
Lines 1001 1030 +29
========================================
+ Hits 885 912 +27
- Misses 116 118 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more seamless conversion between the result objects of different methods. To convert between two result types, the first result is converted to a Dict of field names to values, and then that dict is converted to the target result type. This assumes that all result types have a common set of field names, and for any field in a result that is not in that common set, a custom convert method must be defined that sets default values for those fields in the target result type.