Remove Krotov and GRAPE as sub-packages #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be loaded on-demand and passed to `optimize` via the `method` keyword argument. No need to install GRAPE if you're only going to use Krotov's method. This should also make releases easier, as we don't have to worry about version conflicts to to the Krotov/GRAPE depenencies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
======================================
Coverage 85.2% 85.2%
======================================
Files 9 9
Lines 437 437
======================================
Hits 372 372
Misses 65 65 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be loaded on-demand and passed to
optimizevia themethodkeyword argument. No need to install GRAPE if you're only going to use Krotov's method.This should also make releases easier, as we don't have to worry about version conflicts to to the Krotov/GRAPE depenencies.