Use JLL package to provide GSL binary library#104
Merged
ViralBShah merged 1 commit intoJuliaMath:masterfrom Mar 31, 2020
Merged
Use JLL package to provide GSL binary library#104ViralBShah merged 1 commit intoJuliaMath:masterfrom
ViralBShah merged 1 commit intoJuliaMath:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
+ Coverage 6.99% 7.03% +0.03%
=========================================
Files 189 189
Lines 5348 5277 -71
=========================================
- Hits 374 371 -3
+ Misses 4974 4906 -68
Continue to review full report at Codecov.
|
Member
|
@giordano Should we get this one merged? |
Member
Author
|
Travis is not running because this is a draft PR. I'm opening for review to see how it goes |
96a669b to
7374127
Compare
Member
|
Only the nightly Julia windows is failing. So I think we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only a proof-of-concept to show how this package will look like using the new JLL artifacts.
This pull requested is not intended to be merged yet, as it requires Julia 1.3.