Upgrade to Julia 1.3+, use JLL package to provide FFTW#122
Merged
Conversation
Collaborator
Author
|
Appveyor 1.3 x86 failure will be fixed in rc5 |
This is the first package where I've tried to mix JLL packages with more custom installation procedures, but it seems to more-or-less work.
9e57bc2 to
97b451a
Compare
Member
|
Lookin' good! Would it be possible to use a BinaryBuilder-provided MKL upon request instead of using Conda? |
Collaborator
Author
https://github.com/JuliaBinaryWrappers/MKL_jll.jl/releases/tag/MKL-v2019.0.117%2B0 |
Member
|
Yeah, I know it exists, I'm just not sure how one would restructure the provider choice since it's actually loading a package rather than just picking up an existing library. |
Collaborator
Author
|
I think just like how we do this: https://github.com/JuliaMath/FFTW.jl/pull/122/files#diff-ed74277d7f2e98f12cf51e6b8be90705R44-R48 We could generate a few lines to load in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first package where I've tried to mix JLL packages with more
custom installation procedures, but it seems to more-or-less work.