Skip to content

[Do not merge] Use the new LBT mechanism introduced in Julia to forward to MKL#62

Closed
ViralBShah wants to merge 2 commits intomasterfrom
lbt
Closed

[Do not merge] Use the new LBT mechanism introduced in Julia to forward to MKL#62
ViralBShah wants to merge 2 commits intomasterfrom
lbt

Conversation

@ViralBShah
Copy link
Copy Markdown
Member

@ViralBShah ViralBShah commented Feb 26, 2021 •
edited
Loading

I suppose we should only merge this upon releasing Julia 1.7.

  • Build 1.7 master
  • Pkg.add(url="git@github.com:JuliaLinearAlgebra/MKL.jl", rev="lbt")
  • using MKL
  • Pkg.test("MKL")

This will replace OpenBLAS with MKL (and is the same procedure for another BLAS). The tests pass on mac, but not on linux. Can someone review if my modifications here are all good?

@ViralBShah
Copy link
Copy Markdown
Member Author

ViralBShah commented Feb 26, 2021 •
edited
Loading

cc @KristofferC @andreasnoack @staticfloat

@ViralBShah
Copy link
Copy Markdown
Member Author

ViralBShah commented Feb 26, 2021

Should fix #46

@ViralBShah ViralBShah mentioned this pull request Feb 26, 2021
Closed
@giordano
Copy link
Copy Markdown
Contributor

giordano commented Feb 26, 2021

Should fix #46

Are you sure?

@ViralBShah
Copy link
Copy Markdown
Member Author

ViralBShah commented Feb 26, 2021

Should fix #46

Are you sure?

We now unconditionally use only the 64_ suffixed symbols on 64-bit setups. Internally, LBT forwards those to the regular BLAS symbols for ILP64 BLAS in MKL. But I guess that could lead to 32-bit and 64-bit MKL loaded simultaneously and break. I'm not so sure anymore.

I think if you want to use LP64 BLAS on 64-bit systems, most likely the system image needs to be rebuilt. Help appreciated - if people can try things out.

@KristofferC
Copy link
Copy Markdown
Contributor

KristofferC commented Feb 26, 2021 •
edited
Loading

Got something weird on my Mac:

julia> using LinearAlgebra

julia> @edit LinearAlgebra.BLAS.vendor() # works fine

julia> using MKL

julia> @edit LinearAlgebra.BLAS.vendor() # infinite segfaults

not sure what is going on. Can anyone repro?

@ViralBShah
Copy link
Copy Markdown
Member Author

ViralBShah commented Feb 26, 2021

Yes, getting the same segfaults.

@ViralBShah ViralBShah changed the title Use the new LBT mechanism introduced in Julia to forward to MKL [Do not merge] Use the new LBT mechanism introduced in Julia to forward to MKL Feb 26, 2021
@ViralBShah ViralBShah marked this pull request as draft February 26, 2021 14:53
@KristofferC
Copy link
Copy Markdown
Contributor

KristofferC commented Feb 26, 2021

But other than that, it seems to work quite well.

@ViralBShah ViralBShah closed this Feb 27, 2021
@ViralBShah ViralBShah mentioned this pull request Feb 27, 2021
Merged
@KristofferC KristofferC deleted the lbt branch February 19, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViralBShah @giordano @KristofferC